Skip to content

Improved defaults pr devel #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Aug 9, 2024
Merged

Improved defaults pr devel #181

merged 51 commits into from
Aug 9, 2024

Conversation

gregharvey
Copy link
Member

No description provided.

nfawbert and others added 30 commits January 28, 2022 16:49
* Updated package.json version: 1.1.19
#89) (#91)

* #CE-62820: Added support for composer '2.x' in Drupal 9 provision template.

* #CE-62820: Attempt to fix pull request test cases by providing a default value for the 'new_user' in provision.

* #CE-62820: Attempt to fix pull request test cases by providing a default value for the 'key_name' in provision.

* #CE-62820: Attempt to fix pull request test cases by providing a default values for 'ce_deploy' in provision.

Co-authored-by: David Suissa <david.suissa@codeenigma.com>

Co-authored-by: David Suissa <david.suissa@codeenigma.com>
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.
* Renamed the settings and drush files for ce-dev

* Added nodejs 16.x as default version

* Added lhci_run role by default

* Some tweaks in the config

* Added the if statement to read info from an optional settings.local.php file
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [moment](https://github.com/moment/moment) from 2.27.0 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.27.0...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixing ce_provision vars in container builds.

* Fixing ce_deploy vars in container builds.
* Fixing ce_provision vars in container builds.

* Fixing ce_deploy vars in container builds.

* Adding the option to build manually the containers.
* Fixing ce_provision vars in container builds.

* Fixing ce_deploy vars in container builds.

* Adding the option to build manually the containers.

* Still missing some vars.
* Fixing ce_provision vars in container builds.

* Fixing ce_deploy vars in container builds.

* Adding the option to build manually the containers.

* Still missing some vars.

* Setting older version of Ubuntu for containers.
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix setup on a Mac: use Docker Compose V2 with the new 'cgroup' parameter.

* Fix setup on a Mac: use Docker Compose V2 with the new 'cgroup' parameter. (#113)

* Documentation update for docker composer v2.

* Temporarily disabling LHCI for Drupal 9 due to an HTML issue.

* Preparing release of 1.2.0.

* Updating release version in package.json.

* Updating yarn dependencies.

* Committing package-lock.json (new file with newer node versions).

* Revert "Committing package-lock.json (new file with newer node versions)."

This reverts commit 8912d3d.

* Revert "Updating yarn dependencies."

This reverts commit 94be4ab.

---------

Co-authored-by: Kristjan Lilleoja <kristjan.lilleoja@yumuuv.com>
Co-authored-by: Kristjan Lilleoja <kristjanlilleoja@me.com>
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

* Suppressing unattended-upgrades.

* Adding composer plugins to Drupal 8 deployments.

* Adding the phpcodesniffer plugin for D8.
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Bump semver from 5.7.1 to 5.7.2

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: gregharvey <greg.harvey@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gregharvey and others added 21 commits July 18, 2023 18:41
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

* Suppressing unattended-upgrades.

* Adding composer plugins to Drupal 8 deployments.

* Adding the phpcodesniffer plugin for D8.

* Updating PHP versions for templates.
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

* Suppressing unattended-upgrades.

* Adding composer plugins to Drupal 8 deployments.

* Adding the phpcodesniffer plugin for D8.

* Updating PHP versions for templates.

* Downgrading Drupal and drush for LGD.
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

* Suppressing unattended-upgrades.

* Adding composer plugins to Drupal 8 deployments.

* Adding the phpcodesniffer plugin for D8.

* Updating PHP versions for templates.

* Downgrading Drupal and drush for LGD.

* LGD prebuilt template needs to use drupal9 images.
* Adding a Drupal 9 template to ce-dev.

* Testing nodejs version change with blank template.

* Incrementing version for release.

* There's no drupal9 template for ce-deploy.

* Updating Drupal templates.

* Removing docs steps for ansible because they cannot work.

* Suppressing unattended-upgrades.

* Adding composer plugins to Drupal 8 deployments.

* Adding the phpcodesniffer plugin for D8.

* Updating PHP versions for templates.

* Downgrading Drupal and drush for LGD.

* LGD prebuilt template needs to use drupal9 images.

* Adding another composer plugin for LGD template builds.
* 66912: Added Drupal10 template

* 66912: Added post_tasks section

* 66912: Updated version to 1.2.4

* 66912: Recovered drupal8

* 66912: Fixed drupal10 text
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [debug](https://github.com/debug-js/debug) from 4.1.1 to 4.3.4.
- [Release notes](https://github.com/debug-js/debug/releases)
- [Commits](debug-js/debug@4.1.1...4.3.4)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…u:22.x'. (#99)

Co-authored-by: David Suissa <david.suissa@codeenigma.com>
Co-authored-by: gregharvey <greg.harvey@gmail.com>
* Upgrading base container to bullseye-slim.

* Noticed some extra references to buster.
* Creating devel containers with Debian 'bookworm' (12).

* Moving ansible and boto3 installs to apt.

* apt installed ansible is not in /usr/local.

* Updating dependencies.

* Updating yarn.lock again.

* Fixing ansible paths for ce-provision 2.x.

* Adding new variables required by controller.

* Installing ansible in a virtual environment on the container before running ce-provision.

* Missing a slash!

* Also missed a &&.

* Adding python venv support via apt in base image.

* Temporarily adding python3-venv to the controller Dockerfile.

* Installing Ansible as the ce-dev user to avoid perms issues.

* Upgrading ubuntu in CI to have systemd as default and disabling Ansible upgrades.

* Missing an ansible install var.

* Documentation for testing containers.

* Adding vscode settings to .gitignore.

* Adding devel versions of Dockerfiles and config.

* Fixing bug caused by set line.

* Updating CI for export.sh changes.

* Adding ability to switch ce-provision own branch and config branch.

* Restoring the 1.x branch.

* Missed a couple of 2.x references.

* Updating yarn.lock again.

* Do not base off the unison container.

* Fixing 1.x Ansible installation.
* Merging 1.x.

* Getting rid of bookworm in 1.x because Ansible cannot install on it.

* Missing paths to Dockerfile in some CI jobs.
@gregharvey gregharvey requested a review from DionisioFG July 2, 2024 15:32
Copy link

gitguardian bot commented Jul 2, 2024

⚠️ GitGuardian has uncovered 29 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5592904 Triggered Generic Password b0dc9d9 templates/localgov/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password 62e753e templates/drupal9/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password c884a4f templates/localgov/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password 06bf830 templates/localgov/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password b0dc9d9 templates/localgov/ce-dev/ce-dev.compose.yml.j2 View secret
5592904 Triggered Generic Password 845c62f templates/drupal10/ce-dev/ce-dev.compose.yml.j2 View secret
5592904 Triggered Generic Password 845c62f templates/drupal10/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b0dc9d9 templates/drupal9/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password 7c9e1bc templates/drupal9/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password 7c9e1bc templates/drupal8/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password b0dc9d9 templates/localgov/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b0dc9d9 templates/drupal9/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password c884a4f templates/drupal8/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password c884a4f templates/drupal9/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password b0dc9d9 templates/drupal9/ce-dev/ce-dev.compose.yml.j2 View secret
5592904 Triggered Generic Password 7c9e1bc templates/localgov/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password 845c62f templates/drupal10/ce-dev/ce-dev.compose.prebuilt.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal9/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal9/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal8/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal10/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal10/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal9/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal9/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal8/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal10/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal8/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password d3393a3 templates/drupal10/ce-dev/ansible/provision.yml.j2 View secret
5592904 Triggered Generic Password b3d7123 templates/drupal8/ce-dev/ansible/provision.yml.j2 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarqubecloud bot commented Jul 2, 2024

@gregharvey gregharvey merged commit b01f5e7 into devel Aug 9, 2024
5 of 7 checks passed
@gregharvey gregharvey deleted the improved_defaults-PR-devel branch August 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants